🌱 Minor improvements to api validation tests#2001
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom Apr 5, 2024
Merged
🌱 Minor improvements to api validation tests#2001k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
Conversation
* Adds a helper function which registers a cleanup helper if an object was created * Moves infrav1 tests under a separate context in anticipation of adding other version tests.
API versions must be registered in the scheme before starting the envtest in order for conversion webhooks to be registered.
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lentzi90
approved these changes
Apr 5, 2024
Contributor
lentzi90
left a comment
lentzi90
left a comment
There was a problem hiding this comment.
Very good find!
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comprises 3 small cleanups:
/hold